https://bugzilla.wikimedia.org/show_bug.cgi?id=34684

Daniel Friesen <mediawiki-b...@nadir-seen-fire.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mediawiki-bugs@nadir-seen-f
                   |                            |ire.com

--- Comment #3 from Daniel Friesen <mediawiki-b...@nadir-seen-fire.com> 
2012-02-24 11:36:17 UTC ---
This was to do with the PathRouter code.

The PathRouter has an extra check to make sure all parameters have been
replaced:
For example this:
$router->add( "/wiki/$1", array( 'title' => "$1$2" );
Should never succeed because $2 will never be replaced. It's also just in case
there is a situation where it's not a coding error and that is in fact
happening because the pattern is not a proper match.

The problem was that it couldn't tell the difference between a $# or $key in
the pattern that wasn't replaced and a $1 that came from the url.

I've updated the tests to include some cases I didn't think of originally. And
I've fixed the issue by switching to a preg_replace_callback based system.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to