https://bugzilla.wikimedia.org/show_bug.cgi?id=34687

       Web browser: ---
             Bug #: 34687
           Summary: ParserOptions::mEditSection is not pushed down to
           Product: MediaWiki
           Version: 1.20-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: Unprioritized
         Component: Parser
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: vita...@yourcmc.ru
    Classification: Unclassified
   Mobile Platform: ---


Created attachment 10089
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=10089
Patch to fix this problem

There was a change in r99250 and also r100379 in MediaWiki 1.18.1 which was
intended to always cache editsection link placeholders inside the parser output
so they could then be added/removed when fetching the parser output from cache.

Since this change, if you just create a ParserOptions object, call
$options->setEditSection(false), then parse something using these options and
just call $output->getText(), you'll get editsections links in the output
regardless of $options->setEditSection(false).

The fix is to always pass parser option to ParserOutput::setEditSectionTokens
(don't know why it wasn't already so). The patch is attached.

I also think you should backport this change to 1.18.next (1.18.2 ?) as it
breaks some extensions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to