https://bugzilla.wikimedia.org/show_bug.cgi?id=34762
Web browser: ---
Bug #: 34762
Summary: Patching DatabaseMysql.php's close to meet
specification
Product: MediaWiki
Version: 1.20-svn
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Database
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: christ...@quelltextlich.at
Classification: Unclassified
Mobile Platform: ---
Created attachment 10120
--> https://bugzilla.wikimedia.org/attachment.cgi?id=10120
Resetting mConn upon closing MySQL database connection
The documentation of the close function in includesDatabase.php:730--736 says
that 'close' should return true, when called for an already closed connection.
Calling close on an already closed DatabaseMysql object fails, by something
like:
-----8<------
PHP Warning: mysql_close(): 4 is not a valid MySQL-Link resource in
/home/christian/sources/Wikimedia/shreddingPHPUnit/dummy.php on line 13
Warning: mysql_close(): 4 is not a valid MySQL-Link resource in
/home/christian/sources/Wikimedia/shreddingPHPUnit/dummy.php on line 13
-----8<------
The problem seems to be that mConn is not cleared upon closing DatabaseMysql.
The attached patch resolves this issue.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
