https://bugzilla.wikimedia.org/show_bug.cgi?id=34961
--- Comment #26 from Fut.Perf. <fut.p...@googlemail.com> 2012-03-10 09:39:45 UTC --- (In reply to comment #24) > No, there did not used to be two message sets. Logs just used the one message > set and prepended the username (along with a space) to create the final log > wording. That pretty straightforwardly was bad for localization. That's not the way I read the code. According to the old version of the code in https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Title.php?revision=96846&view=markup&pathrev=96847, the text for the null edit in the page history was produced by these lines: 3336 $commentMsg = ( $moveOverRedirect ? '1movedto2_redir' : '1movedto2' ); 3337 $comment = wfMsgForContent( $commentMsg, $this->getPrefixedText(), $nt->getPrefixedText() ); So this was based on [[MediaWiki:1movedto2]] (or [[MediaWiki:1movedto2_redi]] respectively). The text for the log entry was produced by an entirely independent computation a bit further down, presumably calling[[MediaWiki:Logentry-move-move]] somehow: $log = new LogPage( 'move' ); 3453 $logType = ( $moveOverRedirect ? 'move_redir' : 'move' ); 3454 $log->addEntry( $logType, $this, $reason, array( 1 => $nt->getPrefixedText(), 2 => $redirectSuppressed ) ); If there is a good localization-related reason to change this second part of the code and calculate the log entry in a different way, that's fine. But why couldn't we return the first part of the code to the way it was, making log entry and edit summary again independent of each other? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
