https://bugzilla.wikimedia.org/show_bug.cgi?id=35456
Antoine "hashar" Musso <has...@free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |has...@free.fr
Resolution| |WORKSFORME
--- Comment #4 from Antoine "hashar" Musso <has...@free.fr> 2012-03-26 15:59:47
UTC ---
git-review accepts as an optional argument the branch name to interact with.
When that argument is not specified, it fallback to look for the defaultbranch
parameter in the .gitreview file.
Every branch should have a .gitreview having a correct defaultbranch value. We
probably do not want to force people to use something like: `git-review
REL1_19`
Output example using test/mediawiki/core and a .gitreview file NOT having
default branch set:
$ git-review -v REL1_19
2012-03-26 17:57:30.318755 Running: git log --color=never --oneline
HEAD^1..HEAD
2012-03-26 17:57:30.335452 Running: git remote
2012-03-26 17:57:30.340266 Running: git branch -a --color=never
2012-03-26 17:57:30.346184 Running: git branch --color=never
2012-03-26 17:57:30.351537 Running: git log HEAD^1..HEAD
Found topic 'REL1_19' from parsing changes.
2012-03-26 17:57:30.372507 Running: git rev-parse --show-toplevel
2012-03-26 17:57:30.377682 Running: git remote update gerrit
Fetching gerrit
2012-03-26 17:57:32.224581 Running: git rebase -i remotes/gerrit/REL1_19
2012-03-26 17:57:32.505708 Running: git config --get color.ui
2012-03-26 17:57:32.510419 Running: git log --color=always --decorate --oneline
REL1_19 --not remotes/gerrit/REL1_19
2012-03-26 17:57:32.531614 Running: git push gerrit
HEAD:refs/for/REL1_19/REL1_19
remote: Resolving deltas: 0% (0/2)
remote:
remote: New Changes:
remote: https://gerrit.wikimedia.org/r/3742
remote:
To ssh://has...@gerrit.wikimedia.org:29418/test/mediawiki/core.git
* [new branch] HEAD -> refs/for/REL1_19/REL1_19
$
Now with a defaultbranch specified:
$ git-review -v
2012-03-26 17:59:01.654284 Running: git log --color=never --oneline
HEAD^1..HEAD
2012-03-26 17:59:01.671722 Running: git remote
2012-03-26 17:59:01.678109 Running: git branch -a --color=never
2012-03-26 17:59:01.684509 Running: git branch --color=never
2012-03-26 17:59:01.690706 Running: git log HEAD^1..HEAD
Found topic 'REL1_19' from parsing changes.
2012-03-26 17:59:01.711494 Running: git rev-parse --show-toplevel
2012-03-26 17:59:01.716346 Running: git remote update gerrit
Fetching gerrit
2012-03-26 17:59:03.550708 Running: git rebase -i remotes/gerrit/REL1_19
2012-03-26 17:59:03.848351 Running: git config --get color.ui
2012-03-26 17:59:03.853355 Running: git log --color=always --decorate --oneline
REL1_19 --not remotes/gerrit/REL1_19
You have more than one commit that you are about to submit.
The outstanding commits are:
598114c (HEAD, REL1_19) yeah defaultbranch rocks
22570d4 yah testing file for confirmation
Is this really what you meant to do?
Type 'yes' to confirm: yes
2012-03-26 17:59:07.938479 Running: git push gerrit
HEAD:refs/for/REL1_19/REL1_19
remote: Resolving deltas: 0% (0/2)
remote:
remote: New Changes:
remote: https://gerrit.wikimedia.org/r/3743
remote:
To ssh://has...@gerrit.wikimedia.org:29418/test/mediawiki/core.git
* [new branch] HEAD -> refs/for/REL1_19/REL1_19
$
Thus, I am marking this issue as work for me
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
