https://bugzilla.wikimedia.org/show_bug.cgi?id=28419
--- Comment #40 from Daniel Friesen <mediawiki-b...@nadir-seen-fire.com> 2012-04-01 04:10:22 UTC --- (In reply to comment #39) > > > Also, I would change the cryptParams() function to defaultCryptParams() > > > and > > > replace preferred format with current format. > > > > Hmmm... 'default' might work. At the same time they don't feel like > > 'default'. > > It's more of a callback saying "I'm hashing a password for the first time, > > please create the parameters to run the algorithm with." Using 'default' > > makes > > it sound a little static when it's not, since cryptParams() returns things > > like > > completely random salts. > > Default isn't perfect, but all I know is that it shouldn't be preferred. It > just gives the wrong idea. Maybe newCryptParams()? Idk. "preferred", yeah that of course doesn't fit. This is creation of parameters for a crypt() call, not comparing data against the preferential format defined in settings. Are we mixing cryptParams() and isPreferredFormat() up here? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
