https://bugzilla.wikimedia.org/show_bug.cgi?id=35046
Krinkle <krinklem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Summary|[Regression] jquery.ui |[Regression] jquery.ui
|buttons in Monobook |buttons order reversed in
|exchanged |Vector
--- Comment #4 from Krinkle <krinklem...@gmail.com> 2012-04-11 22:02:00 UTC ---
The Vector css has this non-standard rule:
> .ui-dialog .ui-dialog-buttonpane button { float: right; }
That rule was causing the first button to be on the right, the second button
to be on the left of that and so forth. Per jQuery UI documentation and all
other scripts, plugins and skins ever written by and for jQuery UI, the order
is wrong in Vector, and right in all other skins.
See for example: http://jqueryui.com/demos/dialog/#modal-confirmation
$( "<div>" ).dialog({
height: 140,
buttons: {
"Delete all items": function() {
$( this ).dialog( "close" );
},
Cancel: function() {
$( this ).dialog( "close" );
}
}
});
The "Delete all items" is the first button and "Cancel" to the right of that
(as it should be).
That is restored in Vector by removing said css rule from
/resources/jquery.ui/themes/vector/jquery.ui.dialog.css
and instead adding a float rule for the button container, copied from
the default jQuery UI theme:
/resources/jquery.ui/themes/default/jquery.ui.dialog.css : line 18
Other plugins/skins are not affected.
https://gerrit.wikimedia.org/r/4757
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
