https://bugzilla.wikimedia.org/show_bug.cgi?id=36007
Jon <jrob...@wikimedia.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jrob...@wikimedia.org
--- Comment #2 from Jon <jrob...@wikimedia.org> 2012-04-19 12:41:26 UTC ---
Agreed with all the above although not too sure about not using jQuery's
hasClass for testing.. seems overkill... as the rest of the tests already
assume jquery is fine. I have a hasClass function in application.js but this is
different.
When I first rewrote MobileFrontend I had to write unit tests to test existing
content which had lots of globals so some of the tests are not written how I'd
like them. I think it's safer now to address the problems above you describe.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
