https://bugzilla.wikimedia.org/show_bug.cgi?id=1605
Max Semenik <maxsem.w...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|patch-need-review |
Status|ASSIGNED |NEW
CC| |maxsem.w...@gmail.com
--- Comment #64 from Max Semenik <maxsem.w...@gmail.com> 2012-04-20 20:50:46
UTC ---
My review:
* First of all, all PHP development should happen with error_reporting set to
E_ALL | E_STRICT, otherwise you may miss problems like "Undefined variable:
updatestatus in D:\Projects\MediaWiki\extensions\SectionNumber.php on line 82".
Or "Notice: Undefined variable: hdepth in
D:\Projects\MediaWiki\extensions\SectionNumber.php on line 87"
* This extension works correctly only when page contains no transcluded
sections, otherwise the numbers go out of sync with those in section edit
links.
* strpos( $parser->mTitle->mPrefixedText, 'Special:' ) === false works only on
English-language wikis, use Title's functions that work with namespaces.
* Overall, the system that relies heavily on action (and retrieves it using an
undocumented variable!) is extremely fragile.
* This extension's syntax ([[section::name]] and [[section::number]]) is
non-standard and should be replaced with magic words.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
