https://bugzilla.wikimedia.org/show_bug.cgi?id=18760
Summary: Must check $wgEnableEmail before showing ANY email related preferences Product: MediaWiki Version: 1.16-svn Platform: All OS/Version: All Status: NEW Severity: major Priority: Normal Component: User preferences AssignedTo: wikibugs-l@lists.wikimedia.org ReportedBy: jida...@jidanni.org It is very important that you test $wgEnableEmail before showing the user ANY email related preferences. Or else we * make the user think the wiki has features enabled but in fact they are disabled. * cause some users to type in personal information that we DO NOT want to collect, and is only useful for disabled features. Please read the definition of $wgEnableEmail in DefaultSettings.php. The following quick workaround in Preferences.php merely shows you where the test should be. You still will need to eliminate duplication within it, and of course test, which I haven't. @@ -270,2 +270,3 @@ ## Email stuff + global $wgEnableEmail; if($wgEnableEmail){#BEGIN QUICK FIX @@ -372,2 +373,3 @@ } + }#END QUICK FIX } -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l