https://bugzilla.wikimedia.org/show_bug.cgi?id=36468

Antoine "hashar" Musso <has...@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Unit tests                  |General/Unknown

--- Comment #1 from Antoine "hashar" Musso <has...@free.fr> 2012-05-03 14:09:45 
UTC ---
I can not reproduce the issue. Please provide a stack trace and the name of
test that cause the error.  

Language::getNamespaces() seems to be summing array which does not work
whenever one of the operand is null instead of an empty array. 

Code is:

$this->namespaceNames = self::$dataCache->getItem( $this->mCode,
'namespaceNames' );
$validNamespaces = MWNamespace::getCanonicalNamespaces();
$this->namespaceNames = $wgExtraNamespaces + $this->namespaceNames +
$validNamespaces;

Most probably the data cache is empty / corrupted and $this->namespaceNames
ends up being null which break the sum.

Two possibles fixes would be:
- use array_merge() if it supports merging an array with a null value
- throw a nice exception whenever the getItem calls returns null

Redirecting to General component since that is not really related to unit
tests.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to