https://bugzilla.wikimedia.org/show_bug.cgi?id=36431
Jeroen De Dauw <jeroen_ded...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeroen_ded...@yahoo.com
--- Comment #2 from Jeroen De Dauw <jeroen_ded...@yahoo.com> 2012-05-06
15:04:33 UTC ---
Two different issues here:
* We need to not save invalid data to the page table if it was rejected from
the secondary tables. Might be better to have a Content::isValid() method that
is called before save (but can also be used at other places, such as preview or
whatever) and does all the needed checks (in case of WikibaseItem this includes
some reads to the db to see if no duplicate stuff is entered). This method can
then remove the invalid data and continue the save or abort it, and also return
the encountered issues to the caller. One thing to keep in mind is that any
changes to this kind of info should always be written to both the page table
and the secondary tables, preferably in the same transaction.
* We need some way of dealing with race conditions. If a save happens and we do
a read, and it turns out all is well, we must still be sure that no write that
creates a previously absent conflict does not happen before the save completes.
Not sure how to do this in MediaWiki. Probably needs some investigation.
Let's not put all the storage related stuff into a single bug, so I suggest
splitting up the second issue into it's own bug, so this one can be closed once
the first one has been addressed.
> check one database and then continue, leaving the remaining databases
What databases are you talking about? AFAIK we will only have a single master
db for the Wikidata (repo) wiki. This db will hold both the page table and the
secondary tables needed for duplication checks, so we won't need to care about
any additional stuff we set up for answering queries or other stuff I think.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
