https://bugzilla.wikimedia.org/show_bug.cgi?id=36693
--- Comment #1 from Yaron Koren <yaro...@gmail.com> 2012-05-09 13:31:48 UTC --- Hi, thanks for this patch! SD has needed something like this for a long time. The calls to array_merge_recursive_distinct() and http_build_query() seem like overkill here - are you sure they're needed? In the case of #formlink, they're used because #formlink allows arbitrary parameters (it adds them all to the query string) - #drilldown doesn't do that. And #formlink didn't use them until a few months ago: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php?r1=110324&r2=110685 Also, any objections to renaming this function to #drilldownlink? Or to changing the name of the parameter "filter" to "filters"? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
