https://bugzilla.wikimedia.org/show_bug.cgi?id=37496
Daniel Kinzler <daniel.kinz...@wikimedia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |daniel.kinz...@wikimedia.de
AssignedTo|wikidata-bugs@lists.wikimed |daniel.kinz...@wikimedia.de
|ia.org |
--- Comment #1 from Daniel Kinzler <daniel.kinz...@wikimedia.de> 2012-06-18
15:14:52 UTC ---
Implementation is in gerrit for review: https://gerrit.wikimedia.org/r/11865
I have implemented this based on the normal wikitext diff, using the same
side-by-side layout and recycling the CSS. As a context (instead of the line
number), the path to the changed value is shown, using the keys from our
internal JSON representation. That sucks, of course.
This implementation doesn't work correctly at the moment, because it depends on
some other things to be fixed, most importantly bug 37680, but also bug 37691
and bug 37683.
Anyway, some actual UI design seems in Order here. Some thoughts:
* side-by-side seems useless.
* instead, show added, removed and modified properties in a single column
* for modified properties, show a word-based diff
* it may be nice to just show the (old) item with highlighted modifications
(inline diff)
* diffs will often be for a single atomic change. It could be useful to make
this a special case.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
