https://bugzilla.wikimedia.org/show_bug.cgi?id=18758

Brad Jorsch <b-jor...@alum.northwestern.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b-jorsch@alum.northwestern.
                   |                            |edu

--- Comment #10 from Brad Jorsch <b-jor...@alum.northwestern.edu> 2012-06-19 
15:25:17 UTC ---
I agree with Roan regarding the cases from comment 5. Although I note that a
"mark unread" feature in core might well use the API via ajax to do the
marking, like the watch/unwatch tab does now.

To add to case 2, personally I want to be able to add a "seen" button to the
watchlist lines. But I'm concerned that I might load my watchlist, spend 20
minutes reading changes to other pages, and then click "seen" on a page and
lose notification of the edits to that page made during the 20 minutes I was
doing other stuff. This is the reason I never use the existing "Mark all pages
visited" button on the watchlist. So I'd ideally code my "seen" button to say
"set wl_notificationtimestamp to just after revision X".

As for setting wl_notificationtimestamp to invalid values, it appears that it's
either treated as a boolean "changed" value (e.g. for watchlist bolding) or
compared against the revision timestamp using >= (e.g. for recentchanges or
history highlighting). So as long as it's a valid timestamp it shouldn't matter
what specific time it is set to.

In gerrit change 11965, I took the approach of using the ApiPageSet module so
multiple pages can be marked at once, if desired. For convenience in my desired
use case, I allow selection of the timestamp (for a single page) by passing a
revision id so it's not necessary to do a separate query to prop=revisions just
to find the necessary timestamp.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to