https://bugzilla.wikimedia.org/show_bug.cgi?id=18943
Freek Dijkstra <softw...@macfreek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|WORKSFORME |
--- Comment #3 from Freek Dijkstra <softw...@macfreek.nl> 2009-05-27 14:36:57
UTC ---
Thanks for the feedback. You are right, and now have two separate bugs.
Somehow, the bad title involved is "".
The $title is NULL instead of an object.
Bug 1. Bad titles are not handled gracefully.
Resolution. Please update the code to:
> function makeWlhLink( &$title, $caption, &$skin ) {
> if (is_object($title)) {
> $wlh = SpecialPage::getTitleFor( 'Whatlinkshere',
> $title->getPrefixedDBkey() );
> } else {
> $wlh = SpecialPage::getTitleFor( 'Whatlinkshere' );
> }
> return $skin->makeKnownLinkObj( $wlh, $caption );
> }
(I usually prefer to write this as try ... catch, but no exception was
raised, so I used an if statement.)
Bug 2. cleanupTitles.php does not detect this case, and the error remains.
I will have to look into this last one, find a solution, put it in a new
bugreport and add the bug ID here.
Thanks.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
