https://bugzilla.wikimedia.org/show_bug.cgi?id=37225

--- Comment #64 from Alexandre Emsenhuber [IAlex] <ialex.w...@gmail.com> 
2012-07-11 18:35:09 UTC ---
So first my apologies to have caused this bug with Gerrit changeset #6079. I
did already mentioned MySQL's "consistent read" feature there, but I did not
see that problem. I did choose to use "FOR UPDATE" in EditPage.php to catch
edit conflicts before executing WikiPage::doEdit(), but it seems that this is
causing more harm than good.

An easy solution is to remove the "FOR UPDATE" and use the already-present
conflict detection code in WikiPage::updateRevisionOn(), since it put a
condition on the page_latest field with fetched value when updating the
database row. So a value mismatch will trigger a transaction rollback and an
edit-conflict form.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to