https://bugzilla.wikimedia.org/show_bug.cgi?id=38307
Krinkle <krinklem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |krinklem...@gmail.com
--- Comment #5 from Krinkle <krinklem...@gmail.com> 2012-07-11 20:06:32 UTC ---
(In reply to comment #4)
> Do the JavaScript bits duplicate PHP descriptions though, or load on top of
> them?
There are no javascript bits yet, hence this request.
Once implemented they should use the same messages.
Come to think of it, this logic is not in the Language class (despite the fact
that we use it as Language:: commaList, it actually just uses Message.
So in ResourceLoader:
* Add message key "comma-separator" to your module definition
* Use array.join( mw.msg( 'comma-separator' ) );
So although it can be simplified, its really trivial to just do yourself.
And in case you're wondering if this is inconsistent with the server side, it
isn't, because the server side implementation of Language::commaLIst is
essentially the same:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=languages/Language.php;h=3ee959eb7a8314d7192acf32e17139994aa5d03f;hb=905d83e3ad0bc3e85438349537ff80dd999e7fc3#l3016
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
