https://bugzilla.wikimedia.org/show_bug.cgi?id=37987
Daniel Kinzler <daniel.kinz...@wikimedia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |Highest
Severity|normal |critical
--- Comment #1 from Daniel Kinzler <daniel.kinz...@wikimedia.de> 2012-07-26
14:07:01 UTC ---
Setting this to critical, because inadvertently editing old revisions leads to
data loss.
To reiterate the issue:
If the current user is not (or should not be) able to edit the item revision
that is currently shown, the UI should not present edit functionality. There
are three cases where this is true:
1) the revision shown is not the current one
2) the user is blocked
3) the user has insufficient privileges (possibly because the page is
protected, or because editing in general is somehow restricted)
Reasons 2 and 3 are covered by Title::userCan( 'edit' ), and I hope there's
already a javascript variable that conveys the same information. If not, we'll
have to create one.
Reason 1 should hopefully also be detected easily from JavaScript.
Implementation note: In the past, the loading of the Wikibase JS modules was
supressed for old revisions and if the user wasn't allowed to edit. This should
NOT be the case. Instead, the modules should always be loaded, but should only
show editing tools if editing is possible and desired.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
