https://bugzilla.wikimedia.org/show_bug.cgi?id=18890
--- Comment #21 from Bill Mitchell <bill.mitch...@pobox.com> 2009-06-01
09:39:05 UTC ---
OK, I think I've done all I can be expected to here.
1. Re the discussion in Comment#15 - Comment#20 regarding the broken regression
testing, I have run regression testing on the unmodified Cite-MW1.14-r45577
extension and have observed that to fail in the same manner as it fails with
this modified version. Apparently, there is some problem predating the
Cite-MW1.14-r45577 extension with the citeParserTests.txt file, or with the
regression test facility, or with the Mediawiki parser. Failure of regression
testing of this modification to the Cite_body.php file from Cite-MW1.14-r45577
and with the unmodified Cite_body.php file from that release would appear to be
unrelated to any changes made in this modification.
2. Re the portion of Comment#15 re error checking, I have added error checking
code to detect two new error possibilities -- unrecognized Ref tag elements and
orphan hidden refs.
3. Re the portion of Comment#15 re removing unnecessary parts, after looking
back at the code again, I didn't see unnecessary parts to be removed. This is
related to and illustrated by one of the new possible errors -- an orphan
hidden ref error. Such an error is detected at References expansion time, at
which time the orphan hidden ref must be in the stacked refs and must be
distinguishable as a hidden ref. (I hope I'm not confusing anyone by speaking
of "hidden refs", I'm coining terminology here as I go along)
4. Re the portion of Comment#11 suggesting that "define" might be a better term
than "hide", I've done an alternative implementation growing out of Comment#13
("<ref def name=whatever>...</ref>" instead of "<ref hide
name=whatever>...</ref>"). Personally, I like the "ref def" syntax better. I
have not attached the "ref def" version of the code to this bug -- I can do
that if needful, or I can enter a new bug with the "ref def" version, offering
that as a replacement for this bug. Suggestions?
5a. A testwiki for the <ref hide name=whatever>...</ref> version is available
at http://siteslot/testwiki/.
5b. A testwiki for the <ref def name=whatever>...</ref> version is available at
http://siteslot/testwiki2/.
6. Please let me know if I can usefully do any more on this -- problems seen in
testing on the testwikis, further suggestions, whatever.
7. Both testwikis will stay up for now. At some point, I will take them down.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
