https://bugzilla.wikimedia.org/show_bug.cgi?id=38894
Roan Kattouw <roan.katt...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #3 from Roan Kattouw <roan.katt...@gmail.com> 2012-07-31 22:16:52
UTC ---
Not actually fixed.
This is because CentralAuth uses the same hook function for AbortNewAccount and
AbortAutoAccount. This is a problem because AbortNewAccount expects the
returned error to be an HTML string, while AbortAutoAccount expects it to be a
message key. The hook outputs an HTML string to both, which causes the latter
to interpret the HTML string as a message key, which obviously fails terribly.
What's even worse is that docs/hooks.txt claims that both hooks take a message
key. Ugh.
The message key approach is inflexible, though, because TitleBlacklist needs to
pass parameters to the message (like the rule that triggered the block), so I
think a reasonable way to fix this would be to allow the hook to return either
a string or a Message object.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
