https://bugzilla.wikimedia.org/show_bug.cgi?id=39099

--- Comment #10 from Tyler Romeo <tylerro...@gmail.com> 2012-08-07 20:06:20 UTC 
---
(In reply to comment #9)
> >The only reason you're getting these
> >warnings now and not previously is because the original URL functions just
> >returned false on error rather than actually issuing a warning
> 
> Returning false sounds like the more desired behaviour. If the issue is really
> something that cannot be ignored, an exception should be thrown. PHP notices
> are icky. (In this case, I think wfDebug is more appropriate than wfWarn).
> 
> >2) callto scheme error - Can be fixed by adding "callto:" to allowed 
> >protocols.
> 
> If the issue is that Uri.php fails badly when fed an invalid url, making all
> urls valid is not a good solution, as it would defeat the point of doing url
> validation.

I agree, and most likely a switch to wfDebug will be the answer, but I'm still
wondering why and in what context MW would be using invalid URLs like that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to