https://bugzilla.wikimedia.org/show_bug.cgi?id=39473

       Web browser: ---
             Bug #: 39473
           Summary: Running parser test files with phpunit.php should
                    behave like running them with parserTests.php
           Product: MediaWiki
           Version: 1.20-git
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Unit tests
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: danwe...@web.de
                CC: has...@free.fr, krinklem...@gmail.com,
                    m...@everybody.org
    Classification: Unclassified
   Mobile Platform: ---


It seems like when running parser test files with phpunit.php they follow
different rules as when running them with parserTests.php.

If I observed this correctly, phpunit.php collects all articles to be created
with "!!article", creates them, and then it runs tests. With parserTests.php on
the other hand everything is executed in the order it is defined. In some tests
it can be important whether a article already exists or not.

There might be other behavioral differences here as well. The whole thing seems
incredibly odd to me since there is also some redundant code and the initial
globals set up in ParserTest::setupGlobals() are slightly different from
globals set up in NewParserTest::setupGlobals().

If there is no good reason against this, both classes, ParserTest and
NewParserTest should be reduced to one, or at least one base class/interface.
The goal should be that when running phpunit.php parser tests behave exactly
like running parserTests.php

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to