https://bugzilla.wikimedia.org/show_bug.cgi?id=40343

--- Comment #2 from MZMcBride <b...@mzmcbride.com> 2012-09-29 01:32:56 UTC ---
(In reply to comment #1)
> It appears this array defaults to empty. If things are being removed from a
> production site these are specified on a config level.
> 
> I think from a configuration perspective this is actually useful as it gives
> control to mediawiki admins... what was the reason for not thinking this is
> useful and should be killed?

The question is whether this configuration variable continues to be a sensible
implementation of the desired behavior (hiding code that uses particular CSS
classes). $wgMFRemovableClasses pre-dates the existence of MediaWiki:Mobile.css
and MediaWiki:Mobile.js. Reading MaxSem's comment at bug 30421 comment 13, it
seems like this configuration variable should be killed.

On the other hand, having read your comments at bug 30421 comment 17, perhaps
this configuration variable has legitimate uses (and simply needs better
documentation).

Looking at the Wikimedia Foundation's use of this variable
(<https://noc.wikimedia.org/conf/InitialiseSettings.php.txt>):

---
'wmgMFRemovableClasses' => array(
    'default' => array( 'table.metadata',
               '.metadata mbox-small',
               '.metadata plainlinks ambox ambox-content',
               '.metadata plainlinks ambox ambox-move',
               '.metadata plainlinks ambox ambox-style', ),
),
---

Is this appropriate to set on every wiki? Would it be better to allow
individual wiki administrators to specify which classes to remove (hide)
instead? I'm not sure.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to