https://bugzilla.wikimedia.org/show_bug.cgi?id=40541
--- Comment #8 from Tyler Romeo <tylerro...@gmail.com> 2012-09-29 16:02:31 UTC --- (In reply to comment #7) > I added an ugly hack to wfExpandUrl in Gerrit change #25721 to ignore this > assumption > if the site owner has enabled $wgSecureLogin. However, I think it would be > best > to back up and actually define a couple of things: > > 1) What does it mean if $wgServer starts with http://? Is it that there is no > ssl available / intended, and MediaWiki should never generate an https link? > Or > should we assume that it's a default configuration, and we can override it if > other settings like $wgSecureLogin are set? Honestly, if MediaWiki is explicitly requesting an HTTPS link, I think it is erroneous to produce something different, especially with something as ambiguous as what $wgServer's scheme is. I think PROTO_HTTPS should give https regardless of $wgServer. In reality, I would love to just finish https://gerrit.wikimedia.org/r/22167 and stop using wfExpandUrl in new code altogether. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
