https://bugzilla.wikimedia.org/show_bug.cgi?id=19406
--- Comment #6 from Patrick <m...@patrick-nagel.net> 2009-07-02 04:53:47 UTC --- Hi Yaron, thanks for including the patch in version 1.7.3. I now realise that my patch actually fixed two issues - the one with the case and "VARBINARY users", and another one with autocompletion only working on the beginning of the property value, not on a beginning of a word in a property value. I had forgotten about the second fix already, and thus didn't mention it (which now causes a bit of confusion... sorry). In line 133 of includes/SF_AutocompleteAPI.php you changed [...] LIKE '% " [...] back to [...] LIKE '%\_" [...] which looks logical when taking into account what line 130 does. But the thing is, that column value_xsd of table smw_atts2 does *not* use underscores instead of spaces (at least not in my two Wiki databases), which leads to the problem that autocompletion only finds beginnings of property values, but not beginnings of words in property values. Knowing this, and thinking a bit more about it, we also need to remove lines 130 and 131, since they make it impossible to have a space in the autocomplete search string (substring). I'll use the following example property value to illustrate the situation: "Software Engineer / IT Security Engineer" Current situation in 1.7.3 (and before my patch against 1.7.2): - Autocompleting on "Soft" shows the string - Autocompleting on "Security" does not show the string - Autocompleting on "Security Engineer" does not show the string Situation after my (unchanged) old patch (against 1.7.2): - Autocompleting on "Soft" shows the string - Autocompleting on "Security" shows the string - Autocompleting on "Security Engineer" does not show the string Situation after my new patch (against 1.7.3, which again changes "%\_" to "% " like my old patch did, and additionally removes the space-to-underscore conversion in the autocomplete substring): - Autocompleting on "Soft" shows the string - Autocompleting on "Security" shows the string - Autocompleting on "Security Engineer" shows the string -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
