https://bugzilla.wikimedia.org/show_bug.cgi?id=19546
Roan Kattouw <roan.katt...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |roan.katt...@gmail.com
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Roan Kattouw <roan.katt...@gmail.com> 2009-07-07 00:07:44
UTC ---
(In reply to comment #1)
> That's how Modern does it. Some other skins like Monobook created the div
> dynamically, using the following code from wikiBits:
>
> if ( document.getElementById( 'column-content' )
> && document.getElementById( 'content' ) ) {
> // MonoBook, presumably
> document.getElementById( 'content' ).insertBefore(
> messageDiv,
> document.getElementById( 'content' ).firstChild
> );
> } else if ( document.getElementById('content')
> && document.getElementById( 'article' ) ) {
> // Non-Monobook but still recognizable (old-style)
> document.getElementById( 'article').insertBefore(
> messageDiv,
> document.getElementById( 'article' ).firstChild
> );
> }
>
> That's of course ugly enough. I think the best way would be to change the
> "Monobook, presumably" way to always insert the message div right before the
> #top element. Or better yet, do that and change all skins so that they *have*
> a
> #top element (which would be useful in any case) and remove the skin branching
> from wikibits.js.
>
Fixed this logic to do proper skin detection in r52821.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
