https://bugzilla.wikimedia.org/show_bug.cgi?id=42715

--- Comment #16 from Aaron Schulz <aschulz4...@gmail.com> ---
(In reply to comment #15)
> (In reply to comment #12)
> > Thanks a bunch for looking into this, Antoine!
> > 
> > This makes me fear for the other gazillion extensions that have jobs. Is
> > this a
> > regression in the job queue that must be fixed?
> 
> runJobs always calls ack() even if run() returned false. The only way it
> won't
> is if:
> a) the runner dies in the middle of the job (e.g. some serious fatal or
> exception)
> b) ack() fails for some reason

And it's (b). The translation notification job constructor is missing the $id
parameter (it should have one like all the under job classes under /job). I've
made https://gerrit.wikimedia.org/r/#/c/37372/2 to work around this problem,
but the extension should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to