https://bugzilla.wikimedia.org/show_bug.cgi?id=43475

--- Comment #3 from Aude <aude.w...@gmail.com> ---
an additional issue is that ORMRow uses Database::insertID() but mLatestId
never gets set and is null.

$this->setField( 'id', $dbw->insertId() );

Now, PostgreSQL supports ' RETURNING id' as part of the query.  We could make
'returning' ( 'returning' => 'id_field_name' ) as an optional query parameter
for DatabasePostgres::insert().

and then be able to set mLatestId when inserting a single row. (which ORMRow
does, and likely elsewhere in the code)

I need to poke more at the code to be sure this could work and that Tim's
patch, which is part of the fix, also works okay with Wikibase and other places
it's used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to