https://bugzilla.wikimedia.org/show_bug.cgi?id=43594
--- Comment #10 from Bawolff (Brian Wolff) <bawolff...@gmail.com> --- (In reply to comment #4) > Whether it changed or not, why should we hide notices about using the wrong > calling conventions in PHP or some other similar type things? I'm just not > sold > on this, though it's probably not a big deal. I agree 100% that we should not be surpressing warnings about incorrect calling conventions. However there are other E_STRICT warnings that sometimes need to be surpressed (the timezone thing for example). >The biggest issue with E_STRICT is that it throws a warning if you make a >static call to a function which doesn't have the static keyword. However, in >order to be compatible with PHP4, we need to omit it. >From a core prespective, given how long ago PHP4 support has been dropped, that's not the most convincing argument. However functions should work as they are documented, and wfSuppressWarnings() is documented as surpressing all warnings. >On a more general note, best practice is to disable this kind of error on >production machines, however in PHP 5.4, the deliberate error suppression code >is actually un-suppressing errors! That seems very broken to me. Didn't even realize that with the original bug, but yeah that's not good. (In reply to comment #7) > Also, this should be back-ported to any previous MW versions that are still > supported. Yeah probably, especially with it overriding the user's error_reporting settings to enable E_STRICT. /me wonders how to go about doing that/request that it be done in our new git world. Something for me to read up on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
