https://bugzilla.wikimedia.org/show_bug.cgi?id=19797

           Summary: Improve LogEventsList::showLogExtract (patch)
           Product: MediaWiki
           Version: 1.16-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: need-review, patch
          Severity: enhancement
          Priority: Normal
         Component: Page rendering
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: happy-me...@live.com


Created an attachment (id=6353)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6353)
Adds functionality to LogEventsList::showLogExtract().  Against r53416.

This is a very useful function, however it currently takes a rather bizzarre
input format.  It requires as a first parameter an output source, but this
currently *has* to be the global $wgOut.  As such I don't really understand why
the variable needs to be passed, when the global could just be redeclared. 
This patch allows the $out parameter to be *either* $wgOut *or* a
string-by-reference, which a) makes the function much more versatile, and b)
provides more of a reason to have the parameter in the first place. Tested
against r53416.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to