https://bugzilla.wikimedia.org/show_bug.cgi?id=43821

       Web browser: ---
            Bug ID: 43821
           Summary: [mediawiki/extensions/UploadWizard.git] / resources /
                    mw.FormDataTransport.js makes use of deprecated
                    jQuery.browser and uses string comparison
           Product: MediaWiki extensions
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: UploadWizard
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: rainerril...@hotmail.com
                CC: mtrac...@member.fsf.org, nischay...@gmail.com,
                    wikibugs-l@lists.wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/UploadWizard.git;a=blob;f=resources/mw.FormDataTransport.js;h=25deb49e3a5aa66ed27d38e097410eef260cbb3a;hb=master#l26

l.26 of UpWiz/resources/mw.FormDataTransport.js compares two strings. This
makes the condition true for my current Firefox version ("17.0" < "7.0" ===
true) so, a more resource insensitive method is used instead of the native
FormData() 
This is not the intended behaviour; "this.gecko" should be only true for
Firefox versions lower than 7.0
(https://bugzilla.mozilla.org/show_bug.cgi?id=649150).

To fix the issues, it needs to
1) eliminate the use of deprecated $.browser
2) when comparing versions, compare them as numbers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to