https://bugzilla.wikimedia.org/show_bug.cgi?id=43632

Uimanov Aleksey <s9gf4...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s9gf4...@gmail.com

--- Comment #2 from Uimanov Aleksey <s9gf4...@gmail.com> ---
I am the user who posted demonstration above.

You are writing 

> This is currently prevented by line 257 in SRF_Gallery.php:
>   if ( $imgTitle->exists() ) {

> We still need to check that the file exists, of course. Not sure what the best
> method is. Maybe something like this:

>   $imgFile = wfFindFile( $imgTitle );
>   if ( $imgFile && $imgFile->isVisible() ) {


This code belongs to function addImageProperties, but using debug printing i
have figured out that it does not even called.

So i belive the guilty code is 

if ( $this->params['imageproperty'] !== '' && in_array(
$this->params['imageproperty'], $printReqLabels ) || $this->params['redirects']
!== '' && in_array( $this->params['redirects'], $printReqLabels ) ) {

at line 148 of SRF_Gallery.php

Actually, I dont even understand what this condition checks. All after the 

    $this->params['imageproperty'] !== ''

code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to