https://bugzilla.wikimedia.org/show_bug.cgi?id=45591
Web browser: ---
Bug ID: 45591
Summary: Inconsistent returns in
EchoNotificationController::notify()
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Keywords: easy
Severity: trivial
Priority: Unprioritized
Component: Echo
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: s...@reedyboy.net
CC: agarr...@wikimedia.org, bs...@wikimedia.org,
rkald...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
In one path false is returned by the code, but a return above it returns
nothing. Same for the end of the code.
Either add a return value in the first return and at the end of the function,
and as such, update the documentation. Or remove the single return value.
The return value is not used in any current code path
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
