https://bugzilla.wikimedia.org/show_bug.cgi?id=46579
--- Comment #11 from Matt Walker <mwal...@wikimedia.org> --- (In reply to comment #9) > The problem I'm finding is that the majority of the overrides on English > Wikipedia are trivial. That's somewhat surprising to me; and then I'm surprised that I'm surprised :p However; the example you bring to the table raises my point quite well -- there's a template embedded in the 'rollback-success' message. The current method exposes that; the old method would not. Is this important? If not, is it trivial in all cases? (In reply to comment #10) It's a decent argument. How many users are affected by this though; clearly there are at least two. How many users are getting an improved experience from this; I don't know. How many readers are getting an improved experience from this -- potentially quite a few; especially if we go ahead and start respecting a readers browser requested locale by default and/or start using ULS more heavily. I personally think the benefits outweigh the drawbacks. (In general) I don't actually have deploy authority - so I could not, even if I wanted to, revert the change; the language team will make up it's mind when it wakes up in a couple of hours and then effect what they think to be the most appropriate change. In the meantime; I will leave you with the three options I gave the language team when I wrote the patch (there could be more) -- Niklas, possibly without fully understanding the ramifications, recommended option C. The other two are just as technically feasible. I await your thoughts on what would be the most correct way forward. -- Option A - Use the message cache fallback chain at the requested language lookup on wiki for message if no message: lookup via cdb cache if no message: for each language: lookup on wiki for the message -- Option B - Use message cache fallback chain only at the wiki source language for each language: lookup on wiki for the message if no message and language is wgLanguageCode: lookup via cdb cache w/ original requested language if message: break -- option C - always prefer on wiki messages for language: get on wiki message if no message get message from cdb My comments at the time: "It seems to me that option B might be more correct because we will get every possible on wiki customization (up to the native language of the wiki), then every possible cached version (up to english), then any on wiki customization (from native language to english). Option A seems like it would give us english far too soon -- ie: it would only be able to give us on wiki replacements for fallbacks only if the language cache for the message didn't exist at all." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l