https://bugzilla.wikimedia.org/show_bug.cgi?id=46774
MZMcBride <b...@mzmcbride.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |b...@mzmcbride.com
--- Comment #4 from MZMcBride <b...@mzmcbride.com> ---
(In reply to comment #0)
> Allow the user to specify whether to use 'Expand Recent',
> 'Expand all', ... as default strategy for comment
> visibility.
I'm not sure this is the correct approach to take here. The default behavior
should just be sensible. It looks like Gerrit already supports a "expand recent
comments" feature. Could the site-wide default be changed here?
(In reply to comment #3)
> The more we can get upstream, the less we have to maintain
> ourselves :-)
Thanks for working on this.
> A patch allowing the user to specify whether to use
> 'Expand Recent', 'Expand all', ... as default strategy
> for comment visibility is uploaded to upstream gerrit for
> review at:
>
> https://gerrit-review.googlesource.com/#/c/44162/
In software development and design, the defaults are hugely important as most
users never set custom preferences. It's unclear whether this proposed
changeset changes the site-wide default or just adds a user preference. As I
said above, I'd rather not see a new user preference here, but if one is added,
I think there's still the unresolved issue of a sane default here.
There's no time when I can think of that the current behavior (collapsing all
but the most recent comment) would be appropriate. Auto-expanding the most
recent comments (plural) seems like a sensible default site-wide and would
likely eliminate the need for a user preference.
All that said, the JavaScript-based solutions have some advantages, such as
auto-collapsing certain kinds of comments (such as those from jenkins-bot).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
