https://bugzilla.wikimedia.org/show_bug.cgi?id=47408
Web browser: ---
Bug ID: 47408
Summary: Inline comments wind up on wrong line in lines shown
by +10⇧, +10⇩, etc
Product: Wikimedia
Version: wmf-deployment
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Git/Gerrit
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: bjor...@wikimedia.org
CC: christ...@quelltextlich.at, innocentkil...@gmail.com,
marcin.cies...@gmail.com, rlan...@gmail.com
Classification: Unclassified
Mobile Platform: ---
I've been seeing this bug for a while, where entering a comment on line N would
sometimes store it for line N-1 instead. I've just now figured out how to
reliably reproduce it.
1. Use the +10⇧, +10⇩, or "skipped X common lines" links to show additional
lines.
2. On one of those newly-shown lines, enter an inline comment. Note the line
number.
3. Reload. See that the comment is one line above where it should be.
Watching the AJAX requests in Firebug, I see that submissions for lines shown
at page load are sending the correct line number in the lineNbr field, while
submissions for lines shown as above are sending the wrong number.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
