https://bugzilla.wikimedia.org/show_bug.cgi?id=47045
--- Comment #15 from Chris Steipp <cste...@wikimedia.org> --- I just added https://gerrit.wikimedia.org/r/#/c/60021/ That *can* be deployed, which will revert the query change from Ie331ec7ef3b461ae10 and allow IPv4 queries to be returned quickly. Comparison of query performance on enwiki below. However, this will break querying for IPv6 ip addresses. For that, we need a slightly more involved fix. I'll start working on that right now. But if getting back functionality is worth breaking IPv6 lookups (which have been broken until Ie331ec7ef3b461ae10), then the patch can be merged and deployed, if the Stewards give an ok. mysql:wikiadmin@db1056 [enwiki]> explain SELECT * FROM abuse_filter_log LEFT -> JOIN abuse_filter on (af_id=afl_filter) WHERE afl_user = 0 AND -> afl_user_text='90.221.128.138'; +------+-------------+------------------+--------+---------------+----------+---------+------------------------------------+---------+-------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +------+-------------+------------------+--------+---------------+----------+---------+------------------------------------+---------+-------------+ | 1 | SIMPLE | abuse_filter_log | ref | afl_user | afl_user | 8 | const | 4343552 | Using where | | 1 | SIMPLE | abuse_filter | eq_ref | PRIMARY | PRIMARY | 8 | enwiki.abuse_filter_log.afl_filter | 1 | Using where | +------+-------------+------------------+--------+---------------+----------+---------+------------------------------------+---------+-------------+ 2 rows in set (0.08 sec) mysql:wikiadmin@db1056 [enwiki]> explain SELECT * FROM abuse_filter_log LEFT JOIN abuse_filter on (af_id=afl_filter) WHERE afl_ip=afl_user_text AND afl_user = 0 AND afl_user_text='90.221.128.138'; +------+-------------+------------------+--------+-----------------+---------+---------+------------------------------------+------+------------------------------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +------+-------------+------------------+--------+-----------------+---------+---------+------------------------------------+------+------------------------------------+ | 1 | SIMPLE | abuse_filter_log | ref | afl_user,afl_ip | afl_ip | 257 | const | 4 | Using index condition; Using where | | 1 | SIMPLE | abuse_filter | eq_ref | PRIMARY | PRIMARY | 8 | enwiki.abuse_filter_log.afl_filter | 1 | Using where | +------+-------------+------------------+--------+-----------------+---------+---------+------------------------------------+------+------------------------------------+ 2 rows in set (0.04 sec) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
