https://bugzilla.wikimedia.org/show_bug.cgi?id=47653

Kai Nissen <kn.bugzi...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bawolff...@gmail.com,
                   |                            |bryan.tongm...@gmail.com
          Component|General/Unknown             |File management
            Version|unspecified                 |1.20.4
           Assignee|kn.bugzi...@gmail.com       |wikibugs-l@lists.wikimedia.
                   |                            |org
            Product|Wikimedia                   |MediaWiki
   Target Milestone|---                         |1.21.0 release

--- Comment #4 from Kai Nissen <kn.bugzi...@gmail.com> ---
The protocol type that has been used to get the file info from
commons.wikimedia.org gets cached by the parser cache. This will happen vice
versa, if the parser caches when requesting with https.

I customized the ForeignAPIRepo for commons to always use the secure protocol
when requesting the commons API, but changing ForeignAPIRepo::getThumbUrl() to
strip the protocol and make the src attribute protocol-relative seems to be the
solution here.

I will provide a patch this weekend.

@MZMcBride: The other images that are not provided by commons were also changed
to protocol-relative.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to