https://bugzilla.wikimedia.org/show_bug.cgi?id=47872

Krinkle <krinklem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #15 from Krinkle <krinklem...@gmail.com> ---
Closing this as wontfix.

The classic edit toolbar has long been deprecated. The default was replaced
with WikiEditor on Wikimedia in a 2010 deployment. And since a few releases it
is now bundled with new MediaWiki releases as well.

Since then development has started on [[mw:VisualEditor]] which will be
launched soon.

Despite all that, I've spend a fair amount of effort over the last months to
come up with a brand new API for the classic edit toolbar: mw.toolbar because
mwCustomEditButtons is fundamentally flawed and cannot be repaired and kept up
with the latest technologies.

Any and all issues you may have with mwCustomEditButtons are from hereon
invalid. Please use mw.toolbar instead. Note that mw.toolbar has nothing to do
with WikiEditor or VisualEditor, it is a new API for the classic editor you are
so familiar with.

I can't make any promises for how long the classic toolbar and this new
mw.toolbar will be supported, but at least it has been renewed to work with all
the latest technologies so it should be a relatively cheap burdon for us to
maintain.

So, long story short: Change:

> if ( wgAction === 'edit' ) {
>     mwCustomEditButtons[mwCustomEditButtons.length] = {...};
> }

to:

> if ( mw.toolbar ) {
>     mw.toolbar.addButton( { ... } );
> }

If there are any bugs with that, please file a new bug report and be sure to
mention "mw.toolbar" in its subject. I'll do my best to address if/when there
are any issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to