https://bugzilla.wikimedia.org/show_bug.cgi?id=20756


Brion Vibber <br...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |br...@wikimedia.org,
                   |                            |fvass...@wikimedia.org
         AssignedTo|wikibugs-                   |rhals...@wikimedia.org
                   |l...@lists.wikimedia.org       |
           Keywords|                            |shell




--- Comment #2 from Brion Vibber <br...@wikimedia.org>  2009-09-23 18:26:28 UTC 
---
The live servers have an obsolete copy of LanguageDe.php class file:

/apache/common/wmf-deployment/languages/classes/LanguageDe.php

This little guy explicitly excepted 4-digit numbers from getting the thousands
separator:

<?php
/** German
 *
 * @ingroup Language
 */
class LanguageDe extends Language {

        /*
         * German numeric format is "12 345,67" but "1234,56"
         * Copied from LanguageUk.php
         */

        function commafy($_) {
                if (!preg_match('/^\d{1,4}$/',$_)) {
                        return
strrev((string)preg_replace('/(\d{3})(?=\d)(?!\d*\.)/','$1,',strrev($_)));
                } else {
                        return $_;
                }
        }
}

It's since been removed from the main code, but it's still on most of our
servers -- looks like our sync scripts aren't actually removing files that
shouldn't be there anymore.

Rob and/or Fred can you take a peek at our scap, sync-common-all, etc sync
scripts and see if we need to tweak the rsync options so these old files get
cleared out?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to