https://bugzilla.wikimedia.org/show_bug.cgi?id=50347
--- Comment #5 from Tim Starling <tstarl...@wikimedia.org> --- (In reply to comment #4) > among other issues, I think we should not rely on include_once and have the > mergeMessageFileList check for and omit any missing extension files. > > see https://gerrit.wikimedia.org/r/71056 That is fine, but note that it wouldn't have avoided downtime in the recent case. We have to abort when there is a PHP fatal error, which causes include_once() to return false, so we have to check the return value from include_once. But WikibaseDataModel does an explicit "return" from the file scope, which causes include_once() to return null. That's why mergeMessageFileList.php continued to fail even after WikibaseDataModel was checked out. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
