https://bugzilla.wikimedia.org/show_bug.cgi?id=49935

--- Comment #26 from kipod <fur.hew...@gmail.com> ---
(In reply to comment #25)
> kipod, that path of code in the library will never get executed from ULS. If
> you read the code again, you will see that instead of using jquery.i18n
> message
> loading mechanism, which is generic, not written specifically for MW, we have
> our  own message loading and saving mechanism, that always use asynchronous
> loading. Look for the MWMessageStore definition in the code. Thanks.

not sure i understand. this code has your signature/copyright messsage, and
appears in the tree under "univerals language selector". 
what is the generic library this was imported from? 
is it used for anything other than ULS?
if it's never executed, why is it there? what's the point of keeping dead code
in the tree?

is it possible to remove all the dead code from the project?
i think this will help volunteers (and non-volunteers) to identify the *real*
problems a bit easier.

in any event, if this code is never executed, then we can't blame "async:false"
for the lockups, so "someone" has to figure out the real cause for the lockups
many users reported. 
if you think some other code change maybe solved the problem, it may be
worthwhile going back to those people to find out if the problem still exists.

peace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to