https://bugzilla.wikimedia.org/show_bug.cgi?id=52418
Web browser: ---
Bug ID: 52418
Summary: 'name' in tourSpec for on-wiki tour should be
optional, warn if it doesn't match
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: Unprioritized
Component: GuidedTour
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: sp...@wikimedia.org
CC: lwell...@wikimedia.org, mflasc...@wikimedia.org,
swall...@wikimedia.org, tc...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
If you create an on-wiki tour MediaWiki:Guidedtour-tour-mytour.js but the
tourSpec object you pass to gt.defineTour contains
name: 'My Tour',
then GuidedTour fails with
TypeError: definedTours[tourName] is undefined
http://localhost/wiki/extensions/GuidedTour/modules/ext.guidedTour.lib.js
Line 921
This happens because the name must exactly match the tour name from the page
title.
1. DRY, don't make tour author supply it in this case (pass the expected tour
name to the callback)
2. If you do supply it and it doesn't match, defineTour() should warn 'Optional
\'tourSpec.name\' "My Tour" doesn't match on-wiki tour name "mytour"'.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
