https://bugzilla.wikimedia.org/show_bug.cgi?id=52956
Web browser: ---
Bug ID: 52956
Summary: internal.loadTour() accesses definedTours properties
without checking
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: GuidedTour
Assignee: mflasc...@wikimedia.org
Reporter: sp...@wikimedia.org
CC: lwell...@wikimedia.org, mflasc...@wikimedia.org,
swall...@wikimedia.org, tc...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
internal.loadTour() failed for me with
TypeError: definedTours[tourName] is undefined
on ext.guidedTour.lib.js line 921
condition: definedTours[tourName].showConditionally
I'm not sure how this happened, I think my -mw-tour cookie was out of sync with
the modules it needed to load. I'll try to reproduce, but it would be safer to
test if ( definedTours[tourName] && gt.shouldShowTour( .... ) ).
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
