https://bugzilla.wikimedia.org/show_bug.cgi?id=41961

sp...@wikimedia.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christ...@quelltextlich.at

--- Comment #18 from sp...@wikimedia.org ---
(In reply to comment #17)
gitblit required '/' in project paths be changed to %2F, so my Apache
mod_rewrite rules triggered URL-encoding. This worked for a while, but now the
%2F is getting URL-encoded a second time which turns the '%' into %25, and
gitblit chokes on the resulting %25%2f.

I suspect Christian Aistleitner's puppet commit f5a3b40b on Jun 29, which
changed AllowEncodedSlashes from NoDecode to On, probably caused the break. 
(Despite my copious comments as to why it needs to be that way :-) .)

I notice gitblit's own URLs to summaries are much simpler now, instead of the
URL-encoded slashes after summary it is just
  http://git.wikimedia.org/summary/?r=mediawiki/core.git

That's probably simpler to implement in an Apache mod_rewrite rule rather than
this fragile setup of URL-encoding exactly once. I don't know if there's a
simpler format for linking to a file within a project, the same rewrite rules
also used to rewrite to
  
https://git.wikimedia.org/raw/mediawiki%2fextensions%2fexamples.git/HEAD/BoilerPlate%2fREADME

which now has %25%2f s and is likewise broken.

Chad, are gitblit URLs documented anywhere?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to