https://bugzilla.wikimedia.org/show_bug.cgi?id=52324
Kelson [Emmanuel Engelhart] <kel...@kiwix.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |High
Severity|enhancement |major
--- Comment #7 from Kelson [Emmanuel Engelhart] <kel...@kiwix.org> ---
This code was reviewed and merged. But IMO the solution is buggy because new
generated files have a wrong checksum.
I can not explain why, but it seems to me that these files are bigger than they
should (because header checksum position is not equal anymore to filesize-16).
In addition, I ask myself if the method of sorting the mimetypes is the good
one. This forces to loop through all dirents during the file creation (to
change the mimetype id), something which is not very elegant.
Maybe a better approach would be to allow to force a certain mimetype header at
the beginning of the file creation process. In that case, the list of
mime-types would not be created dynamically during the article insertion and we
would have fixed the problem we have with zimdiff/zimpatch.
In any case, I think we should rollback or fix this, because the zimlib is
currently somehow "broken".
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
