https://bugzilla.wikimedia.org/show_bug.cgi?id=55363
Web browser: --- Bug ID: 55363 Summary: Writer function unefficient mimetype dirent entry rewriting Product: openZIM Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: Unprioritized Component: zimlib Assignee: wikibugs-l@lists.wikimedia.org Reporter: kel...@kiwix.org Classification: Unclassified Mobile Platform: --- During the development of zimdiff/zimpatch we had the problem that two ZIM files were almost equal, except that the mimetypes were not sorted in the same way, so all dirent entry mimetype values were different. This was an issue because zimpatches files were not equal to the original files. To avoid this, the zimlib forces currently the order of the mimetypes in the list in the header. They are sorted alphabeticaly. Unfortunately, I see two problems with this: * This changes the specification of the format (we still don't have changed anything in the specifications) * The sorting of the mimetypes is done after all articles are inserted and this needs to rewrite all the dirent entries. Something which is really not efficient/elegant. I think an alternative approach would be to allow to force the mime-type list before inserting the articles. This would shortcut the dynamic creation of this mime-type list and consequently avoid the two problems listed above. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l