https://bugzilla.wikimedia.org/show_bug.cgi?id=54961

TMg <mr.h...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mr.h...@gmx.de

--- Comment #1 from TMg <mr.h...@gmx.de> ---
Don't get me wrong: I like the feature. But I think the checkbox is odd.

What happens if nothing is selected? The checkbox must be hidden or at least
disabled (grayed out). I guess nothing is selected 99% of the time and therefor
the checkbox is useless 99% of the time.

What happens if I click "Find next" and then decide to enable the "within
selection" checkbox? "Find next" changes the selection.

As I said I have a similar feature in my [[dewiki:User:TMg/autoFormatter]]: If
something is selected it uses the selection. If nothing is selected it uses the
full textarea. From what I heard from my users this works as expected.

A simple way to make this visible to the user is to change the title of the
popup from "Search and replace" to "Search and replace in selection". Maybe
change the button from "Replace all" to "Replace all in selection".

Related:
* Bug 40797 (duplicate, but I'm not sure which one to close)
* Bug 23942 (can't have "search and replace" and "insert internal link brackets
without showing a popup" buttons the same time)
* Bug 23992 ("search and replace" broken in Opera 12)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to