https://bugzilla.wikimedia.org/show_bug.cgi?id=39617
--- Comment #30 from C. Scott Ananian <canan...@wikimedia.org> --- And just recapping the objections to the current patch: 1) it changes longstanding parser behavior, possibility of unintended consequences is high 2) it breaks a number of extensions using the parsertests framework, including Parsoid and potentially others like ParserFunction, Scribunto, etc, by changing parser output in an unexpected way. 3) as gwicke points out in comment 18, removing the linebreak means that stylesheets which *want* single-line behavior can't obtain it. 4) It potentially causes dirty diff issues with Parsoid (see bug 56809 for details) Some possible alternative fixes: 1) I hope gwicke can demonstrate an improved CSS fix 2) perhaps Tidy can/should be run for Special pages as well as normal pages. 3) We suck it up and fix Parsoid, ParserFunction, Scribunto, etc to deal with the new output, evangelize editors etc to let them know the parser has changed, etc. To be clear, we haven't reverted the existing patch yet. My position is just that it was committed prematurely, in view of the side effects, and that we need to take a harder look at the other alternatives. I apologize for not catching this issue earlier, before it was committed -- I usually watch Parser-related patches, but I happened to be on vacation. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
